Merge pull request #16 from otherguy/master

Add bash to Dockerfile, add additional service and logging

Dockerfile

@@ -1,6 +1,6 @@
 FROM alpine
-MAINTAINER Alper Kanat <tunix@raptiye.org>
+MAINTAINER Alper Kanat <me@alperkan.at>
-RUN apk --no-cache add curl jq
+RUN apk --no-cache add curl jq bash
 COPY dyndns.sh /
 USER nobody
 ENTRYPOINT exec /dyndns.sh

dyndns.sh

@@ -4,6 +4,7 @@ api_host="https://api.digitalocean.com/v2"
 sleep_interval=${SLEEP_INTERVAL:-300}
 
 services=(
+    "ifconfig.co"
     "ipinfo.io/ip"
     "ifconfig.me"
 )
@@ -29,10 +30,11 @@ while ( true ); do
         echo "Trying with $service..."
 
         ip="$(curl -s $service)"
-
+        test -n "$ip" && break
-	test -n "$ip" && break
     done
     
+    echo "Found IP address $ip"
+
     if [[ -n $ip ]]; then
         for sub in ${NAME//;/ }; do
             record_id=$(echo $domain_records| jq ".domain_records[] | select(.type == \"A\" and .name == \"$sub\") | .id")
@@ -51,6 +53,8 @@ while ( true ); do
                     -H "Authorization: Bearer $DIGITALOCEAN_TOKEN" \
                     -d "$data" \
                     "$url" &> /dev/null
+            else
+                echo "existing DNS record address ($record_data) did not need updating"
             fi
         done
     else