kfir/TodoSystemMicroService-NodeJS
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

bug of delaying the message

Browse source
This commit is contained in:
Kfir Dayan 2023-07-08 11:29:50 +03:00
parent 44feb4d01c
commit f1d02aadc0
3 changed files with 29 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
notification-service/src/rabbitmq/RabbitMQ.ts
View file

@ -30,12 +30,7 @@ export class RabbitMQ {
} }
async create(payload: ITodo, delayTimeForQueue: number) { async create(payload: ITodo, delayTimeForQueue: number) {
let reQueueTime = 0; const message = JSON.stringify({ payload, delayTimeForQueue });
if (delayTimeForQueue > 900) {
reQueueTime = delayTimeForQueue - 900;
delayTimeForQueue = 900;
}
const message = JSON.stringify({ payload, delayTimeForQueue, reQueueTime });
const options = { persistent: true, expiration: delayTimeForQueue.toString() }; const options = { persistent: true, expiration: delayTimeForQueue.toString() };
try { try {
@ -53,41 +48,24 @@ export class RabbitMQ {
console.log('Consumer started, waiting for messages...'); console.log('Consumer started, waiting for messages...');
this.channel.consume(this.queueName, async (message) => { this.channel.consume(this.queueName, async (message) => {
if (message) { if (message) {
const { payload, delayTimeForQueue, reQueueTime } = JSON.parse(message.content.toString()) as { const { payload, delayTimeForQueue } = JSON.parse(message.content.toString()) as {
payload: ITodo; payload: ITodo;
delayTimeForQueue: number; delayTimeForQueue: number;
reQueueTime: number;
}; };
console.log('Received notification:', payload); console.log('Received notification:', payload);
if (reQueueTime === 0) { try {
try { await MongoDb.updateTodoStatus(payload);
await MongoDb.updateTodoStatus(payload); console.log('Updated todo status in the DB');
} catch { } catch {
await this.create(payload, delayTimeForQueue); await this.create(payload, delayTimeForQueue);
this.channel.ack(message);
console.log('Published new message with delay, THE DB IS DOWN!: ', delayTimeForQueue);
return;
}
} else if (reQueueTime >= 900) {
const newDelayTime = 900;
const newReQueueTime = reQueueTime - 900;
await this.create(payload, newDelayTime);
console.log('Published new message with delay:', newDelayTime);
this.channel.ack(message);
if (newReQueueTime > 0) {
return; // Wait for the next consumer to process the message with the remaining delay
}
} else {
const newDelayTime = reQueueTime;
await this.create(payload, newDelayTime);
console.log('Published new message with delay:', newDelayTime);
this.channel.ack(message); this.channel.ack(message);
console.log('Published new message with delay, THE DB IS DOWN!: ', delayTimeForQueue);
return;
} }
this.channel.ack(message);
} }
}); });
} catch (error) { } catch (error) {

2
request.http
View file

@ -9,7 +9,7 @@ Content-Type: application/json
{ {
"title": "Go to the gym", "title": "Go to the gym",
"description": "Go to the gym at 8pm", "description": "Go to the gym at 8pm",
"due_date": "2023-07-08 10:55:00" "due_date": "2023-07-08 12:00:00"
} }
### update request ### update request

28
todo-service/src/rabbitmq/RabbitMQ.ts
View file

@ -18,20 +18,26 @@ export class RabbitMQ {
} }
async connect() { async connect() {
const connection = await amqp.connect({ try {
protocol: 'amqp', const connection = await amqp.connect({
hostname: env.RABBITMQ_HOST, protocol: 'amqp',
port: parseInt(env.RABBITMQ_PORT), hostname: env.RABBITMQ_HOST,
username: env.RABBITMQ_USERNAME, port: parseInt(env.RABBITMQ_PORT),
password: env.RABBITMQ_PASSWORD, username: env.RABBITMQ_USERNAME,
}); password: env.RABBITMQ_PASSWORD,
this.channel = await connection.createChannel(); });
await this.channel.assertQueue(this.queueName, { durable: true }); this.channel = await connection.createChannel();
await this.channel.assertQueue(this.queueName, { durable: true });
console.log('Channel and queue asserted successfully');
} catch (error) {
console.error('Error connecting to RabbitMQ:', error);
throw error;
}
} }
async create(payload: ITodo, delayTimeForQueue: number) { async create(payload: ITodo, delayTimeForQueue: number) {
const message = JSON.stringify({ payload, delayTimeForQueue }); const message = JSON.stringify({ payload, delayTimeForQueue: delayTimeForQueue });
const options = { persistent: true, expiration: delayTimeForQueue.toString() }; const options = { persistent: true, delayTimeForQueue: delayTimeForQueue.toString() };
try { try {
await this.channel.sendToQueue(this.queueName, Buffer.from(message), options); await this.channel.sendToQueue(this.queueName, Buffer.from(message), options);